CVE-2007-4559 Patch

[TrellixVulnTeam]

Patching CVE-2007-4559

Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.

If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 5.66%.

Quality metrics	Before	After	Change
Complexity	2.40 ⭐	3.31 ⭐	0.91 👎
Method Length	55.75 ⭐	63.67 🙂	7.92 👎
Working memory	5.58 ⭐	4.34 ⭐	-1.24 👍
Quality	80.86% ⭐	75.20% ⭐	-5.66% 👎

Other metrics	Before	After	Change
Lines	138	157	19

Changed files	Quality Before	Quality After	Quality Change
get-gitzer.py	80.86% ⭐	75.20% ⭐	-5.66% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
get-gitzer.py	Installer.install	5 ⭐	183 😞		57.61% 🙂	Try splitting into smaller methods
get-gitzer.py	Installer.download_release	6 ⭐	121 😞	8 🙂	64.59% 🙂	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!