move imports and update doc #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FlavPMU
commented
Jan 30, 2026
FlavPMU
commented
- Add certificate chain and hash verification section to README
- Rename certificate_chain_verification.md to CERTIFICATE-CHAIN-VERIFICATION.md for consistency
- Move cryptography imports to top of mso/verifier.py per maintainer feedback
- Add certificate chain and hash verification section to README - Rename certificate_chain_verification.md to CERTIFICATE-CHAIN-VERIFICATION.md for consistency - Move cryptography imports to top of mso/verifier.py per maintainer feedback
Contributor
Author
|
wait.. I fixed one file only. |
- Move hashlib and datetime imports to top of mso/verifier.py - Move cbor2 import to top of test_09_errors_field.py - Remove all nested import statements per maintainer feedback
Member
|
@FlavPMU I just have released 1.1.0 please resolve the conflicts and ask me the review, I will get back on it to release 1.1.1, right? you wil lfind several improvements in security checks and continuous integration |
Contributor
Author
|
Yes I'm on them. |
Contributor
Author
|
I close this one and open another on a proper branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.