Conversation
When exporting JSON with a limit and a page > 1 set, a leading comma is added before the first item because ($offset !== 0) evaluates to true, resulting in invalid JSON. Replace the offset-based condition with a `$first` flag to track whether any item has been written yet.
sukhwinder33445
force-pushed
the
fix/json-export
branch
from
001cc36 to
d575dbf
Compare
lippserd
approved these changes
Mar 25, 2026
nilmerg
pushed a commit
that referenced
this pull request
Apr 1, 2026
When exporting JSON with a limit and a page > 1 set, a leading comma is added before the first item because `$offset !== 0` evaluates to true, resulting in invalid JSON. Replace the offset‑based condition with a `$first` flag to track whether any item has been written yet. (cherry picked from commit b60448b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When exporting JSON with a limit and a page > 1 set, a leading comma is added before the first item because (
$offset !== 0) evaluates to true, resulting in invalid JSON.Replace the offset-based condition with a
$firstflag to track whether any item has been written yet.fixes #1343