GitHub Actions: ensure bin/make-release.sh still works
#91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sooner or later, someone runs `bin/make-release.sh` on the main branch to make a release. That script requires `composer validate --no-check-all --strict` to pass. This GitHub Action ensures all PRs to fulfill that requirement before being merged.
Al2Klimov
commented
Jan 21, 2026
Member
Author
Al2Klimov
left a comment
Al2Klimov
left a comment
There was a problem hiding this comment.
Test
Success
See the GHA run for this PR.
Failure
https://github.com/Icinga/icinga-php-thirdparty/actions/runs/21204010530/job/60996021995
"ERROR: Composer validate failed"
Member
Is every afternoon at 4pm UTC. What does this uncover what the snapshot build does not? |
Member
Author
|
If this is your serious, then why did you add PR-time GHA e.g here? Icinga/ipl-web#1 What do these uncover what the master-push ones don't? |
Member
|
No no, I don't review this. I asked you a question. Instead of a useful response, I get something that can be summarized as: Nothing, but immediately. |
Member
Author
That's the whole point of GitHub Actions! That you immediately uncover all kind of stuff that shall not be in your master. E.g #82 (review). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sooner or later, someone runs
bin/make-release.shon the main branch to make a release. That script requirescomposer validate --no-check-all --strictto pass.This GitHub Action ensures all PRs to fulfill that requirement before being merged.
Let me know what you think!