Skip to content

[IULRDC-144] add new DoiMetadataService, with expanded metadata#220

Merged
aploshay merged 1 commit intomainfrom
iulrdc-144_more_doi_metadata
Mar 27, 2026
Merged

[IULRDC-144] add new DoiMetadataService, with expanded metadata#220
aploshay merged 1 commit intomainfrom
iulrdc-144_more_doi_metadata

Conversation

@aploshay
Copy link
Copy Markdown
Contributor

@aploshay aploshay commented Mar 7, 2026

  • moves metadata handling out of DoiMintingService into new DoiMetadataService
  • adds expanded metadata handling of optional fields; previously only handled minimal set of required fields

@aploshay aploshay requested a review from rdlebeau March 9, 2026 13:44
Copy link
Copy Markdown
Contributor

@rdlebeau rdlebeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a few suggestions.

Comment thread spec/services/datacore/doi_metadata_service_spec.rb
Comment thread spec/services/datacore/doi_metadata_service_spec.rb Outdated
Comment thread spec/services/datacore/doi_metadata_service_spec.rb Outdated
@aploshay aploshay force-pushed the iulrdc-144_more_doi_metadata branch from 269a4d8 to 5b67bdc Compare March 10, 2026 15:50
@aploshay
Copy link
Copy Markdown
Contributor Author

@rdlebeau see changes addressed in revised push 5b67bdc

@aploshay aploshay force-pushed the iulrdc-144_more_doi_metadata branch from 5b67bdc to 6c2951e Compare March 27, 2026 19:05
Copy link
Copy Markdown
Contributor

@rdlebeau rdlebeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes, no additional requests.

@aploshay aploshay merged commit cf350de into main Mar 27, 2026
2 checks passed
@aploshay aploshay deleted the iulrdc-144_more_doi_metadata branch March 27, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants