Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes small robustness improvements in the quartet2 kernels by avoiding C++ header ODR issues and replacing a brittle dtype assertion with clearer runtime errors.
Changes:
- Replace
assertoninput.dtypewith explicitTypeErrors forweight/inputdtype mismatches (bfloat16 requirement). - Mark
ptx_type_namevariable template specializations asinline constexprin a CUDA header to prevent ODR violations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| kernels/python/quartet2/linear.py | Improves dtype mismatch handling by raising clearer exceptions instead of asserting. |
| kernels/csrc/utils.cuh | Adds inline to constexpr variable templates to avoid multiple-definition/ODR issues from header inclusion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+168
to
+170
| raise TypeError("Weight must be bfloat16. Either set `dtype=torch.bfloat16` or enable autocast`") | ||
| elif input.dtype != torch.bfloat16: | ||
| raise TypeError("Input must be bfloat16. Either cast input to bfloat16 or enable autocast`") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inlineto prevent ODR violations, and better error messages for dtype mismatch