Fix broken title showing '&nbsp' as text#65
Merged
Conversation
The theme head.html uses title_html (which contains ) for the <title> tag. After strip_html | escape, this renders as literal '&nbsp;' text. Override to use site.title instead for the <title> element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The browser tab title displays
ISO/TC&nbsp;211with literal&nbsp;text instead of a space.Cause
The theme's
head.htmlusessite.title_html(set toISO/TC&nbsp;211) for the<title>tag. After Liquid'sstrip_html | escapefilter, the&nbsp;becomes&amp;nbsp;which renders as literal&nbsp;in the browser title bar.Fix
Override
_includes/head.htmlto usesite.title(plain text) for the<title>element. Thetitle_htmlwith&nbsp;is still used correctly in the site header and footer where HTML entities are rendered visually.