Add formatting of PV values #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix linting error Move code to separate function Scientific output only on small/large _absolute_ value
Move function from Block to PVutils Renamed function to match name in ibex_gui Change to using toPrecision in InstrumentPage (when PV values are updated, not in Block)
Despite the bad name, this is to agree with the Java ibex_gui code which uses fixed precision (N decimal places, rather than N significant figures).
Tom-Willemsen
approved these changes
Nov 20, 2024
Member
Tom-Willemsen
left a comment
Tom-Willemsen
left a comment
There was a problem hiding this comment.
Thanks very much for doing this & being willing to add tests - this looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an implementation of PV values formatting as requested in #78
I'm not very experienced with
TypeScriptso this is probably not the best way of doing this but maybe this could be a start?Edit: as noted in the issue, the code now agrees with ibex_gui except in specific cases because
ibex_guidistinguishes betweenintegerandfloattypes but TypeScript only has anumbertype.