Skip to content

Enhancements#86

Merged
alasdairwilson merged 15 commits intomainfrom
insight-panel-user-enhancements
Apr 16, 2026
Merged

Enhancements#86
alasdairwilson merged 15 commits intomainfrom
insight-panel-user-enhancements

Conversation

@sr-murthy
Copy link
Copy Markdown
Collaborator

@sr-murthy sr-murthy commented Apr 10, 2026

  • Separation of unit vs frontend smoke test dependencies in the project TOML + related updates in the workflows + improve the code coverage reporting format
  • Update all workflow actions to the latest stable versions
  • Allow users to write insight panel modules (or scripts) without the define_button function, and with a main function replacing the create_visuals function; add a logging warning for the "old style" insight panel modules
  • Some simplifications and code removal in descriptive_analytics CLI
  • Make IsaricAnalytics a VERTEX dependency, remove the IsaricAnalytics, IsaricDraw and getREDCapData libraries from VERTEX to IsaricAnalytics, and replace all references in the VERTEX libraries and tests with corresponding IsaricAnalytics imports
  • Bump version to 2.0.0
  • Update demo project config JSON files and insight panel modules
  • Add a pylock TOML (with hashed dependencies) including all development and optional dependencies
  • Add Git installation step in Dockerfile - CI failures could be due to the runner using the latest Ubuntu version

@sr-murthy sr-murthy self-assigned this Apr 10, 2026
@sr-murthy sr-murthy added the enhancement New feature or request label Apr 10, 2026
@sr-murthy sr-murthy linked an issue Apr 10, 2026 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 42.85714% with 28 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
vertex/io.py 16.66% 20 Missing ⚠️
vertex/layout/insight_panels.py 72.72% 6 Missing ⚠️
vertex/descriptive_analytics.py 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
vertex/__init__.py 100.00% <100.00%> (ø)
vertex/descriptive_analytics.py 0.00% <0.00%> (ø)
vertex/layout/insight_panels.py 86.23% <72.72%> (-2.94%) ⬇️
vertex/io.py 68.68% <16.66%> (-3.51%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sr-murthy sr-murthy marked this pull request as draft April 10, 2026 10:27
@sr-murthy sr-murthy changed the title Insight panel user enhancements DRAFT: Insight panel user enhancements Apr 10, 2026
@sr-murthy sr-murthy force-pushed the insight-panel-user-enhancements branch 13 times, most recently from 434e069 to 9266c28 Compare April 10, 2026 13:57
@sr-murthy sr-murthy force-pushed the insight-panel-user-enhancements branch from 9266c28 to 5085241 Compare April 10, 2026 13:58
@sr-murthy sr-murthy added the packaging Packaging including management of project metadata and dependencies in the TOML. label Apr 10, 2026
@sr-murthy sr-murthy linked an issue Apr 10, 2026 that may be closed by this pull request
@sr-murthy sr-murthy added the ci Continuous integration label Apr 10, 2026
@sr-murthy sr-murthy linked an issue Apr 13, 2026 that may be closed by this pull request
…om modules that do not define `define_button` and `create_visuals` functions (ref. GitHub issue #81)
@sr-murthy sr-murthy force-pushed the insight-panel-user-enhancements branch from ea9bee6 to 72e2e14 Compare April 14, 2026 13:49
@sr-murthy sr-murthy force-pushed the insight-panel-user-enhancements branch from 980b443 to d1b4542 Compare April 14, 2026 14:28
@sr-murthy sr-murthy changed the title Insight panel user enhancements Enhancements Apr 14, 2026
@sr-murthy sr-murthy force-pushed the insight-panel-user-enhancements branch 4 times, most recently from a096b26 to fe467a7 Compare April 15, 2026 09:21
…d replace refs with corresponding IsaricAnalytics imports + update demo project insight panel modules + update tests
@sr-murthy sr-murthy force-pushed the insight-panel-user-enhancements branch from fe467a7 to f662019 Compare April 15, 2026 09:25
Comment thread vertex/layout/insight_panels.py Outdated
@sr-murthy sr-murthy force-pushed the insight-panel-user-enhancements branch from 9c16f32 to ae6b9c7 Compare April 15, 2026 10:33
Comment thread vertex/layout/insight_panels.py Outdated
Comment thread vertex/io.py
@sr-murthy
Copy link
Copy Markdown
Collaborator Author

sr-murthy commented Apr 15, 2026

@alasdairwilson Thanks for your review, much appreciated. I've left replies to your comments.

…ttons from modules that do not define `define_button` and `create_visuals` functions (ref. GitHub issue #81)
@sr-murthy sr-murthy linked an issue Apr 16, 2026 that may be closed by this pull request
@sr-murthy sr-murthy added the refactor Refactoring changes label Apr 16, 2026
@sr-murthy sr-murthy force-pushed the insight-panel-user-enhancements branch from 99aadab to 2de9a3e Compare April 16, 2026 06:01
@alasdairwilson alasdairwilson merged commit 2574756 into main Apr 16, 2026
6 checks passed
@alasdairwilson alasdairwilson deleted the insight-panel-user-enhancements branch April 16, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration enhancement New feature or request packaging Packaging including management of project metadata and dependencies in the TOML. refactor Refactoring changes

Projects

None yet

2 participants