Skip to content

Removing deprecated Meta class#12418

Open
stevenwinship wants to merge 1 commit into
developfrom
12417-remove-meta-class
Open

Removing deprecated Meta class#12418
stevenwinship wants to merge 1 commit into
developfrom
12417-remove-meta-class

Conversation

@stevenwinship
Copy link
Copy Markdown
Contributor

@stevenwinship stevenwinship commented May 29, 2026

What this PR does / why we need it: Meta class is not needed

Which issue(s) this PR closes:#12417

Special notes for your reviewer:

Suggestions on how to test this: call GET /api/meta/datafile/13962692

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@stevenwinship stevenwinship self-assigned this May 29, 2026
@github-actions github-actions Bot added FY26 Sprint 24 FY26 Sprint 24 (2026-05-20 - 2026-06-03) Original size: 3 labels May 29, 2026
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project May 29, 2026
@stevenwinship stevenwinship added this to the 6.11 milestone May 29, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented May 29, 2026

Coverage Status

Coverage is 24.956%12417-remove-meta-class into develop. No base build found for develop.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

Test Results

397 tests  ±0   382 ✅ +1   37m 7s ⏱️ -39s
 53 suites ±0    15 💤 ±0 
 53 files   ±0     0 ❌  - 1 

Results for commit bf7e049. ± Comparison against base commit 693c89e.

♻️ This comment has been updated with latest results.

@stevenwinship stevenwinship force-pushed the 12417-remove-meta-class branch from 1a6f8a3 to bf7e049 Compare May 29, 2026 21:08
@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project May 29, 2026
@stevenwinship stevenwinship removed their assignment May 29, 2026
@stevenwinship stevenwinship requested a review from landreev May 29, 2026 21:25
@github-actions
Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:12417-remove-meta-class
ghcr.io/gdcc/configbaker:12417-remove-meta-class

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Copy link
Copy Markdown
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you please also remove this method with the path hard-coded:
https://github.com/IQSS/dataverse/blob/develop/src/main/java/edu/harvard/iq/dataverse/DatasetPage.java#L4884-L4889
Aside from that, will approve once Jenkins finishes; probably first thing next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 24 FY26 Sprint 24 (2026-05-20 - 2026-06-03) Original size: 3

Projects

Status: Ready for Review ⏩

Development

Successfully merging this pull request may close these issues.

Remove Meta Class

3 participants