Fix license acceptance pop-up for Archival Format download.#12412
Open
janvanmansum wants to merge 2 commits into
Open
Fix license acceptance pop-up for Archival Format download.#12412janvanmansum wants to merge 2 commits into
janvanmansum wants to merge 2 commits into
Conversation
- A license other than CC0 - Tabular ingested files selecting the the Archival Format option may result in a license acceptance pop-up without buttons and with extra text. This has now been resolved by setting the terms guestbook popup action, just like it was already done for the original format option.
qqmyers
approved these changes
May 29, 2026
Member
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
This looks consistent with the changes made in #9599 - see the first two changes in https://github.com/IQSS/dataverse/pull/9599/changes#diff-690abaf6fd6bfc2b67c1eecbe9f47371ee5cef58635497d74949870bf79110ae - looks like I missed adding it for the archival format case. (It may be this is also needed for the Globus transfer button in the same menu - perhaps @landreev can weigh in there. A fix for that doesn't need to go in this PR, so I'll go ahead and approve).
github-project-automation
Bot
moved this from Ready for Triage
to Ready for QA ⏩
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
No
Suggestions on how to test this:
See issue
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
See: https://github.com/IQSS/dataverse/pull/12412/changes#diff-95d605652d7160e9d89d19dc5dbaefd57f09c23ec1256163976d641eb69aaf17
Additional documentation:
N/a.