Skip to content

IQSS/12244 - fix org citations#12248

Open
qqmyers wants to merge 3 commits intoIQSS:developfrom
GlobalDataverseCommunityConsortium:IQSS/12244_fix_citation
Open

IQSS/12244 - fix org citations#12248
qqmyers wants to merge 3 commits intoIQSS:developfrom
GlobalDataverseCommunityConsortium:IQSS/12244_fix_citation

Conversation

@qqmyers
Copy link
Copy Markdown
Member

@qqmyers qqmyers commented Mar 23, 2026

What this PR does / why we need it: The code had logic to test when a name is for an organization but, due to a typo/cut-paste issue, the CSL Json used to create citations was still marking the entry as not being an organization. This PR fixes the issue.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this: Add a multiword org name as an author, check the chicago style or other styles citations available in the UI/API. (See issue for example).

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: inc.

Additional documentation:

@qqmyers qqmyers added the Size: 0.5 A percentage of a sprint. 0.35 hours label Mar 23, 2026
@qqmyers qqmyers moved this to Ready for Triage in IQSS Dataverse Project Mar 23, 2026
@qqmyers qqmyers added this to the 6.11 milestone Mar 23, 2026
@scolapasta scolapasta moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Mar 24, 2026
@cmbz cmbz added the FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) label Mar 27, 2026
@github-project-automation github-project-automation bot moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS Dataverse Project Apr 1, 2026
@stevenwinship stevenwinship self-assigned this Apr 6, 2026
@stevenwinship stevenwinship moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Apr 6, 2026
@stevenwinship
Copy link
Copy Markdown
Contributor

stevenwinship commented Apr 6, 2026

@qqmyers I'm still seeing the incorrect Author

image

added some logging. looks like it still thinks it's a person

authorJson.getBoolean(isPerson) true
authorJson.getString(fullName) Geological Survey of the Netherlands|
givenName the
familyName ogical Survey of the Netherlands

@cmbz cmbz added the FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) Size: 0.5 A percentage of a sprint. 0.35 hours

Projects

Status: QA ✅

Development

Successfully merging this pull request may close these issues.

CSL citation builder treats organizational author names as personal names, producing garbled styled citations

4 participants