Customize the "Publishing" disclaimer message. Add support for multi line and links#12223
Customize the "Publishing" disclaimer message. Add support for multi line and links#12223stevenwinship wants to merge 3 commits intodevelopfrom
Conversation
stevenwinship
changed the title
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
|
coverage: 24.894%. remained the same — 521-publishing-disclaimer-support-multiline-enbeded-links into develop |
scolapasta
left a comment
scolapasta
left a comment
There was a problem hiding this comment.
See comment about parsing - it's not necessary currently, but in case we change this, for example, to be set at the collection level, someday. (and yes, hopefully by then we'd've retired the JSF, so maybe just being extra careful / paranoid.
| <ui:fragment rendered="#{valid and settingsWrapper.isHasPublishDatasetDisclaimerText()}"> | ||
| <div class="form-group"> | ||
| <p:selectBooleanCheckbox class="text-danger" id="publishDisclaimer" | ||
| itemLabel="#{settingsWrapper.getPublishDatasetDisclaimerText()}" |
There was a problem hiding this comment.
This is straightforward - and currently installation wide setting, but should we consider neing careful and parsing this through our xhtml parsing to make sure only whitelisted tags get used?
There was a problem hiding this comment.
Could you point me to that functionality? I can't find it
There was a problem hiding this comment.
This broke the link for Terms of Use so I need to fix that
There was a problem hiding this comment.
Since this is an Admin only API and the MarkupChecker removed links I will not be using it.
stevenwinship
force-pushed
the
521-publishing-disclaimer-support-multiline-enbeded-links
branch
2 times, most recently
from
100855f to
6cc6c83
Compare
|
Here is the setting update curl command
|
stevenwinship
force-pushed
the
521-publishing-disclaimer-support-multiline-enbeded-links
branch
from
f6caf26 to
e98f790
Compare
stevenwinship
force-pushed
the
521-publishing-disclaimer-support-multiline-enbeded-links
branch
from
e98f790 to
807d3a3
Compare
4 participants
What this PR does / why we need it: Need to allow the setting :PublishDatasetDisclaimerText to be displayed with line feeds and embedded links
Which issue(s) this PR closes: IQSS/dataverse-pm#521
Special notes for your reviewer:
Suggestions on how to test this: use
for line feeds and <a href= for links. Maybe check for attacks/ embedded js code. This is an admin call so it shouldn't be an issue.
Example:
curl -sS -X PUT -d 'I agree to the following:
1. My submission has been fully anonymized (required for all humab subject'''s datasets).
2. My submission does not violate any known copyright laws.
3. I understand that I am liable for any and all violations of the Harvard Repository<a href="https://support.dataverse.harvard.edu/harvard-dataverse-general-terms-use">Terms of Use.' "http://localhost:8080/api/admin/settings/:PublishDatasetDisclaimerText"
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: