Open
Conversation
Member
Author
|
FWIW: Added to triage just to get it discussed - it's not a bug fix, so perhaps should be somewhere in the backlog, but there is community interest. |
scolapasta
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR was implemented 8444 commits ago at QDR. Just updated in response to a community ping. As discussed, it shows the original file format instead of the ingested one. For edit, one can't edit the extension (which you nominally couldn't do before because you could only edit the derived *.tab name and could not touch the original extension). That looks like this at QDR (slight styling differences there):
The file table display is basically as before, with the orig file:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Add tabular and non-tabular files, verify you can see/edit the original file name, checksum matches, etc.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: