Skip to content

Conversation

@landreev
Copy link
Contributor

What this PR does / why we need it:

The page is a 🐖 that penalizes collections for their popularity.

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@landreev landreev changed the title Manage guestbooks page performance Manage Guestbooks page performance Dec 17, 2025
Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-project-automation github-project-automation bot moved this to Reviewed but Frozen ❄️ in IQSS Dataverse Project Dec 17, 2025
@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Dec 17, 2025
@qqmyers qqmyers moved this from Reviewed but Frozen ❄️ to Ready for QA ⏩ in IQSS Dataverse Project Dec 17, 2025
@qqmyers qqmyers added this to the 6.9 milestone Dec 17, 2025
@github-actions

This comment has been minimized.

Copy link
Contributor

@scolapasta scolapasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, we can discuss at standup tomorrow whether we want this for 6.9

@github-project-automation github-project-automation bot moved this from Ready for QA ⏩ to Reviewed but Frozen ❄️ in IQSS Dataverse Project Dec 17, 2025
@scolapasta scolapasta moved this from Reviewed but Frozen ❄️ to Ready for QA ⏩ in IQSS Dataverse Project Dec 17, 2025
@github-actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:manage-guestbooks-page-performance
ghcr.io/gdcc/configbaker:manage-guestbooks-page-performance

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@stevenwinship stevenwinship moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Dec 17, 2025
@stevenwinship stevenwinship self-assigned this Dec 17, 2025
@landreev
Copy link
Contributor Author

As discussed on slack: this has already been deployed on qa.
To get a full picture of how awful it was, develop build would need to be deployed, and the new index_guestbookresponse_dataset_id_guestbook_id would need to be dropped.
But, per everybody on slack, https://qa.dataverse.org/manage-guestbooks.xhtml?dataverseId=99 used to take ~2 min. to load without these fixes.

@cmbz cmbz added the FY26 Sprint 13 FY26 Sprint 13 (2025-12-17 - 2025-12-31) label Dec 17, 2025
@stevenwinship stevenwinship merged commit 015ad0c into develop Dec 18, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Dec 18, 2025
@stevenwinship stevenwinship removed their assignment Dec 18, 2025
@cmbz cmbz added the FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) label Dec 31, 2025
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 13 FY26 Sprint 13 (2025-12-17 - 2025-12-31) FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) Size: 3 A percentage of a sprint. 2.1 hours.

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

6 participants