Dataset type selection step upgrd#949
Draft
jp-tosca wants to merge 34 commits intodataset_type_develop_upgradefrom
Draft
Dataset type selection step upgrd#949jp-tosca wants to merge 34 commits intodataset_type_develop_upgradefrom
jp-tosca wants to merge 34 commits intodataset_type_develop_upgradefrom
Conversation
Conflicts: package-lock.json package.json
The DropdownButtonItem disabled property depends on it.
… and New Review button
…ry and its implementations
…ide click, focus, and escape key
Conflicts: package-lock.json package.json src/dataset/domain/repositories/DatasetRepository.ts src/stories/dataset/DatasetErrorMockRepository.ts src/stories/dataset/DatasetMockRepository.ts
Conflicts: src/dataset/infrastructure/repositories/DatasetJSDataverseRepository.ts src/sections/create-dataset/CreateDataset.tsx src/sections/shared/form/DatasetMetadataForm/MetadataForm/index.tsx src/sections/shared/form/DatasetMetadataForm/index.tsx src/stories/create-dataset/CreateDataset.stories.tsx src/stories/dataset/DatasetErrorMockRepository.ts src/stories/dataset/DatasetMockRepository.ts tests/component/sections/create-dataset/CreateDataset.spec.tsx tests/component/sections/layout/header/LoggedInHeaderActions.spec.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes or changelog update needed for this change?:
Additional documentation: