Skip to content

Fix strict nested matrix inner-validation shard checks#164

Merged
FlorianPfaff merged 2 commits into
mainfrom
codex/fix-nested-matrix-inner-validation-strict
May 25, 2026
Merged

Fix strict nested matrix inner-validation shard checks#164
FlorianPfaff merged 2 commits into
mainfrom
codex/fix-nested-matrix-inner-validation-strict

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Member

Summary

  • validate inner-validation sidecars against outer_test_participant instead of test_participant
  • keep outer, selected, and prediction shard coverage checks on test_participant
  • add a regression test for multi-participant shards whose inner-validation rows use a different inner validation participant

Context

PR #155 added the sharded nested stimulus matrix workflow. Later strict aggregation hardening checks that every file in a multi-participant shard has rows for every outer participant encoded in the shard filename. Real inner-validation rows encode the outer fold in outer_test_participant; test_participant is the inner validation fold. The strict checker was reading test_participant for every sidecar, which could reject valid shard artifacts.

Validation

  • Inspected current main via the GitHub connector.
  • Could not run repository tests locally because this execution environment cannot resolve github.com for a clone/install.
  • Added focused unittest coverage for the real inner-validation row shape; CI should run the focused nested-matrix tests and full static checks.

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 25, 2026 16:33
@github-actions
Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 3.81s
✅ MARKDOWN markdownlint 13 0 0 0 0.89s
✅ PYTHON ruff 128 0 0 0 0.28s
✅ REPOSITORY git_diff yes no no 0.02s
✅ YAML prettier 6 0 0 0 0.49s
✅ YAML v8r 6 0 0 3.49s
✅ YAML yamllint 6 0 0 0.46s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit b837904 into main May 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant