Skip to content

Improve error handling when fetching datasources from Knowledge Space API #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
the-asmit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve error handling when fetching datasources from Knowledge Space API #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions backend/knowledgespace_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,27 @@
import requests
from typing import List, Dict, Optional
from fastapi import HTTPException

KS_BASE = "https://api.knowledge-space.org"


def list_datasources() -> List[Dict]:
"""List all available datasources"""
"""List all available datasources from Knowledge Space API."""
url = f"{KS_BASE}/datasources"
response = requests.get(url, timeout=10)
response.raise_for_status()
return response.json()
try:
response = requests.get(url, timeout=10)
response.raise_for_status()
return response.json()
except requests.exceptions.Timeout:
raise HTTPException(
status_code=504,
detail="Knowledge Space API timed out while listing datasources"
)
except requests.exceptions.RequestException as e:
raise HTTPException(
status_code=502,
detail=f"Failed to fetch datasources from Knowledge Space API: {str(e)}"
)


def get_datasource_metadata(datasource_id: str) -> Dict:
Expand Down