Fix: complete iterator implementation for arbitrary tile ranges#41
Open
Nityahiray wants to merge 1 commit intoINCF:masterfrom
Open
Fix: complete iterator implementation for arbitrary tile ranges#41Nityahiray wants to merge 1 commit intoINCF:masterfrom
Nityahiray wants to merge 1 commit intoINCF:masterfrom
Conversation
Refactor iterator method for improved readability and efficiency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Previous iterator had three bugs:
-Used float division (/) instead of integer (//) causing crashes in python3
-Only handled ranges that were exact multiples of M and N (even tiles)
-Variables 'pre'/'post' referenced in except block before assignment if mask was empty
Fixed by rewriting iterator to:
-Start from the tile containing low0/low1 using integer floor division
-Handles partial edge tiles via bounds check (low0 <= gi < high0)
-Remove fragile nested try/except in favour of a simple for loop