Lo l1c off angle #2637
Merged
Lo l1c off angle #2637
+46
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
added
Ins: Lo
greglucas
force-pushed
the
lo-l1c-off-angle
branch
from
56c7934 to
7eb992c
Compare
The DPS elevation angles (off-angles) need to be relative to the pivot angle.
greglucas
force-pushed
the
lo-l1c-off-angle
branch
from
7eb992c to
92250c7
Compare
greglucas
merged commit 41877e7
into
IMAP-Science-Operations-Center:dev
10 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
In the DPS frame, we need to shift our off-angles to be relative to the current pivot angle which is contained within the pointing set. This is the same shift that happens in l1b. The 3rd commit is the new one here.