Lo l1b off angle #2636
Merged
Lo l1b off angle #2636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
added
Ins: Lo
Contributor
subagonsouth
left a comment
subagonsouth
left a comment
There was a problem hiding this comment.
Just want to check that this is what is desired.
| lats = direction[:, 2] | ||
| # we want this relative to the pivot angle | ||
| # i.e. the off_angle is +/- 2 degrees from the pivot angle | ||
| lats = lats - (90 - l1b_de["pivot_angle"].values[0]) |
Contributor
There was a problem hiding this comment.
I'm wondering if you really want to modify the lats here, or if it would make more sense to modify the lat_bins. The concern is that the off_angle values sort of lose the fact that they relative to the pivot angle. I would think that a user would want off_angle_bins to be in latitudinal degrees.
Collaborator
Author
There was a problem hiding this comment.
I was also not sure, but I spoke with Lo yesterday and they want off_angle to be the range +/- 2, so relative to the pivot_angle no matter what the pivot_angle is. I agree this adds confusion though.
subagonsouth
approved these changes
Jan 29, 2026
greglucas
force-pushed
the
lo-l1b-off-angle
branch
from
de95a46 to
6a8ae25
Compare
greglucas
force-pushed
the
lo-l1b-off-angle
branch
from
6a8ae25 to
bffdb29
Compare
greglucas
merged commit e1263b8
into
IMAP-Science-Operations-Center:dev
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The second commit here is the new code. We need to account for the pivot angle in the "off_angle" calculations so that we are +/-2 degrees from that pivot_angle offset.