Update Query version latest filtering#319
Open
pleasant-menlo wants to merge 2 commits into
Open
Conversation
…_level, descriptor, start_date, and repointing matching but a lower version
tmplummer
reviewed
May 28, 2026
Contributor
tmplummer
left a comment
tmplummer
left a comment
There was a problem hiding this comment.
Thanks for putting up this PR. Looks good to me, but I am going to add some reviewers to get a second set of eyes on this.
There was a problem hiding this comment.
Pull request overview
This PR updates version="latest" query filtering so results keep the latest file per instrument/descriptor/data level/start date/repointing combination instead of only one file per start date.
Changes:
- Replaces start-date-only latest filtering with a composite key.
- Adds parametrized tests covering repointing, descriptor/data-level separation, multi-day filtering, ancillary data, and non-latest passthrough.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
imap_data_access/io.py |
Updates client-side latest-version filtering logic. |
tests/test_io.py |
Adds regression coverage for the new latest filtering behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Before this change, querying with version=latest only returned one file per start date. The desired behavior is that this should return multiple files for each day if the query returns files with multiple descriptors, or if there are multiple repointings in a single day.
Querying with version latest now only excludes a file if there is a higher-version file with matching instrument, data level, descriptor, start_date, and repointing.
Used to return
And now returns
We believe this closes #289