User/Badge: Fix handling of static badge URLs #10791
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit suggests fixing the handling of static URLs like this: http://my.ilias.org/goto.php/usr/6/_bdg?osd_id=6 See: https://mantis.ilias.de/view.php?id=46690
Contributor
|
Thank you very much for the PR @mjansenDatabay ! I agree. Merged and picked to trunk. Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit suggests fixing the handling of static URLs like this: http://my.ilias.org/goto.php/usr/6/_bdg?osd_id=6
See: https://mantis.ilias.de/view.php?id=46690
If approved, this has to be picked to
trunkas well.I introduced a dedicated
badge-related URL handler with #10792 and used corresponding static URLs when emitting new notifications.Nevetheless, I suggest keeping the "legacy badge URL handling" in the user component for a while (e.g. one or two more releases).