Skip to content

Conversation

@MariekeMassa
Copy link
Collaborator

Example names for patient Hendrik Hartman (originally F1) are changed and artifact titles are fixed so they follow the same naming conventions.
Harmke will fix example names for other patient.

@HarmkeKoning
Copy link
Collaborator

Doesn't have Hendrik Hartman an Advance directive? Or did I look over it? In the naming excel where does NR stand for? I can imagine that might be confusing for people who look into it?

Bump validation-outcome-markdown-renderer action to v1.2.2 and simplify SNOMED CT Concept filter in workflow. Update requester reference in CommunicationRequest example to use the correct PractitionerRole resource.
@ArdonToonstra
Copy link
Collaborator

I believe this PR is still in draft phase, until Harmke's changes for the other Patient(s) are added too, correct?

We should keep in mind that Resource.id in FHIR is max 64 char. For now our (new) convention does not violate this. But we should be aware of this an know what part we will truncate if we go above. Saying this because 'Example-1' contains quite some characters. But for now it works out.

@MariekeMassa
Copy link
Collaborator Author

Doesn't have Hendrik Hartman an Advance directive? Or did I look over it? In the naming excel where does NR stand for? I can imagine that might be confusing for people who look into it?

It wasn't there before in our R4 examples, but I see we do have it in STU3 so there is content available for an advance directive for Hendrik Hartman. So let's add it for completeness. And fair point about the NR: it is from the WilsverklaringType codelist (meaning Niet Reanimeren verklaring), but I propose we use DNR.

@MariekeMassa
Copy link
Collaborator Author

I believe this PR is still in draft phase, until Harmke's changes for the other Patient(s) are added too, correct?

We should keep in mind that Resource.id in FHIR is max 64 char. For now our (new) convention does not violate this. But we should be aware of this an know what part we will truncate if we go above. Saying this because 'Example-1' contains quite some characters. But for now it works out.

Yes let's keep it in draft phase. In case there would've been no comments we could've chosen to merge it and let Harmke pick it up from develop, but since there are comments I think it's best from Harmke to work in this branch.

And I wasn't aware of the char limitation. If we want to keep some margin, we could change it to Ex1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants