Skip to content

Fix manifests#78

Open
JulieWinchester wants to merge 8 commits into
mainfrom
fix_manifests
Open

Fix manifests#78
JulieWinchester wants to merge 8 commits into
mainfrom
fix_manifests

Conversation

@JulieWinchester
Copy link
Copy Markdown
Contributor

No description provided.

@vincentmarchetti
Copy link
Copy Markdown
Contributor

vincentmarchetti commented May 22, 2026

A caution on merging this PR, the astronaut_comment_scope.json example, has been modified in this branch beyond fixing syntax errors; some "scope" property key and values have been removed

In the main branch at https://raw.githubusercontent.com/IIIF/3d/refs/heads/main/manifests/10_content_state/astronaut_comment_scope.json the term "scope" appears 8 times, twice as the property key in a SpecificResource in a target property value.

In the fix_manifests branch as modified by the fixing procedure https://raw.githubusercontent.com/IIIF/3d/refs/heads/fix_manifests/manifests/10_content_state/astronaut_comment_scope.json, the term “scope” appears only 2 times; as label text or id strings

@JulieWinchester
Copy link
Copy Markdown
Contributor Author

Thanks @vincentmarchetti! You're right that this PR goes beyond just fixing syntax errors, but that's because the validation errors encompass more than just syntax errors in this case. The manifest you mention (https://raw.githubusercontent.com/IIIF/3d/refs/heads/fix_manifests/manifests/10_content_state/astronaut_comment_scope.json) is a good example of that. It uses 3D comments with cameras, and in the old version this was implemented using content state, which isn't recognized by the validator and isn't the preferred way currently to handle comments with cameras. The PR version of the manifest updates the content to use the newer preferred activating annotations approach.

This does highlight an inconsistency in that the new activating annotation manifests are still in the directory "10_content_state," which will lead to misunderstandings. Also, we already had a version of the astronaut and comments with cameras in "11_special." I've renamed 10 to "10_activating_annotations," moved the astronaut manifest from 11 to 10, deleted the older "scope" manifest, and updated the filename of the whale comments with cameras manifest. Everything should be more consistent and understandable now.

@JulieWinchester
Copy link
Copy Markdown
Contributor Author

I did another round of edits to fix other small spec issues. We have a couple of manifests that need more serious editing, specifically the two manifests for 2D canvas in Scenes. Both use PolygonZSelector, which is not defined by the current draft of Prezi 4. Instead, existing Prezi 4 examples used PointSelector and transform to achieve painting 2D Canvas into 3D Scene, and we should update these manifests accordingly.

6_2d_canvases_in_scene/iiif_canvas_with_bgcolor_backward.json (line 62)
6_2d_canvases_in_scene/iiif_canvas_with_bgcolor_forward.json (line 62)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants