Skip to content

Conversation

@g-braeunlich
Copy link
Collaborator

@g-braeunlich g-braeunlich commented Jan 8, 2026

Description

As a draft, the changes only have been applied to ThermoElastic2D.

  • Move most parts of documentation to the corresponding md file
  • Automatically read docstrings of Conditions and put it into the table
  • Add a directive option :lead: to the problem directive. This automatically creates a link to the github page. Example usage:
    ```{problem} thermoelastic2d
    :lead: Gabriel Apaza @gapaza
    ```
    This will insert a link to https://github.com/gapaza in the table

Type of change

Please delete options that are not relevant.

  • Documentation only change (no code changed)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files
  • I have run ruff check . and ruff format
  • I have run mypy .
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Reviewer Checklist:

  • The content of this PR brings value to the community. It is not too specific to a particular use case.
  • The tests and checks pass (linting, formatting, type checking). For a new problem, double check the github actions workflow to ensure the problem is being tested.
  • The documentation is updated.
  • The code is understandable and commented. No large code blocks are left unexplained, no huge file. Can I read and understand the code easily?
  • There is no merge conflict.
  • The changes are not breaking the existing results (datasets, training curves, etc.). If they do, is there a good reason for it? And is the associated problem version bumped?
  • For a new problem, has the dataset been generated with our slurm script so we can re-generate it if needed? (This also ensures that the problem is running on the HPC.)
  • For bugfixes, it is a robust fix and not a hacky workaround.

@g-braeunlich g-braeunlich self-assigned this Jan 8, 2026
@g-braeunlich g-braeunlich marked this pull request as draft January 8, 2026 15:15
@g-braeunlich g-braeunlich requested a review from markfuge January 8, 2026 15:19
@g-braeunlich
Copy link
Collaborator Author

g-braeunlich commented Jan 8, 2026

@markfuge This is my draft. A generated artifact of the docs already exists here: https://github.com/IDEALLab/EngiBench/actions/runs/20821693995/artifacts/5064370177
Who else should we let review?

@g-braeunlich
Copy link
Collaborator Author

New docs (including the condition docstrings): https://github.com/IDEALLab/EngiBench/actions/runs/20962061394/artifacts/5113911870

@markfuge
Copy link
Member

@g-braeunlich This in general looks good. We will check at the next EngiBench meeting whether we want to have the conditions also listed in the Markdown description and not just in the table, but pending that decision, we can merge it. I will approve for now and we can wait to officially merge after the next meeting decision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants