Skip to content

fix: incorrect stack pointer handling with host call outputs #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Forpee merged 1 commit into from
Jun 16, 2025
Merged

fix: incorrect stack pointer handling with host call outputs #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions third-party/wasmi/crates/wasmi/src/engine/stack/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ impl Stack {
let post_sp = self.values.stack_ptr();
let post_sp = post_sp.offset_from(self.values.base_ptr()) as usize;

for i in 1..=max_inout {
for i in 1..=len_outputs {
let mut vm = stack_witness_vm.clone();
vm.pre_sp = post_sp - i;
vm.P = self.values.stack_ptr().nth_back(i).to_bits();
Expand All @@ -333,7 +333,7 @@ impl Stack {
// We add a dummy write to indicate to tracer that a host function was called
if stack_vms.is_empty() {
let mut vm = stack_witness_vm.clone();
vm.pre_sp = post_sp - 1;
vm.pre_sp = post_sp.saturating_sub(1);
vm.P = self.values.stack_ptr().nth_back(1).to_bits();
stack_vms.push(vm);
}
Expand Down
Loading