Fix swapped Arabic zain short-form GSUB mappings#708
Open
yzn-h wants to merge 1 commit intoIBM:masterfrom
Open
Fix swapped Arabic zain short-form GSUB mappings#708yzn-h wants to merge 1 commit intoIBM:masterfrom
yzn-h wants to merge 1 commit intoIBM:masterfrom
Conversation
Signed-off-by: يزن حمزه <yznhamzeh@gmail.com>
yzn-h
force-pushed
the
fix-arabic-z-short-substitution
branch
from
693b9ce to
41d5599
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes swapped GSUB short-form substitutions for Arabic zain in IBM Plex Sans Arabic.
The current shipped fonts map:
uni0632->uniFEB0.shortuniFEB0->uni0632.shortThis causes
زto use the wrong short-form body in some shaping contexts. This PR swaps those mappings so they resolve to their matching glyph forms:uni0632->uni0632.shortuniFEB0->uniFEB0.shortThis makes zain match the existing behavior of reh (
ر) in the same contexts.Note for maintainers
This repository appears to publish the generated Arabic font binaries, while the README describes source builds from
.vfbfiles using FontLab/AFDKO. I could not find the Arabic source files in the repo, so this PR patches the shipped OTF/TTF/WOFF/WOFF2 binaries directly.If maintainers prefer, this same fix should be applied in the source/build pipeline instead.
Verification
Checked shaping with HarfBuzz:
hb-shape packages/plex-sans-arabic/fonts/complete/ttf/IBMPlexSansArabic-Regular.ttf 'زع'