Skip to content

Fix UID2Prebid compilation for PrebidMobile breaking change #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcaunt wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −17
Open

Fix UID2Prebid compilation for PrebidMobile breaking change #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Sources/UID2Prebid/UID2Prebid.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public actor UID2Prebid {
if let advertisingToken {
userIDs.append(ExternalUserId(
source: source,
uids: [.init(id: advertisingToken, aType: agentType)]
uids: [.init(uniqueId: advertisingToken, aType: agentType)]
))
}
await userIDUpdater.updateUserIDs(userIDs)
Expand Down
18 changes: 9 additions & 9 deletions Tests/UID2PrebidTests/UID2PrebidTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ final class UID2PrebidTests: XCTestCase {
)
await observation(
of: [
ExternalUserId(source: "uidapi.com", uids: [.init(id: "cat", aType: 3)])
ExternalUserId(source: "uidapi.com", uids: [.init(uniqueId: "cat", aType: 3)])
],
by: updater
)
Expand All @@ -68,7 +68,7 @@ final class UID2PrebidTests: XCTestCase {
)
await observation(
of: [
ExternalUserId(source: "uidapi.com", uids: [.init(id: "turtle", aType: 3)])
ExternalUserId(source: "uidapi.com", uids: [.init(uniqueId: "turtle", aType: 3)])
],
by: updater
)
Expand All @@ -93,7 +93,7 @@ final class UID2PrebidTests: XCTestCase {
manager: manager,
thirdPartyUserIDs: {
[
ExternalUserId(source: "example.com", uids: [.init(id: "dog", aType: 3)])
ExternalUserId(source: "example.com", uids: [.init(uniqueId: "dog", aType: 3)])
]
},
userIDUpdater: updater,
Expand All @@ -106,16 +106,16 @@ final class UID2PrebidTests: XCTestCase {
)
await observation(
of: [
ExternalUserId(source: "example.com", uids: [.init(id: "dog", aType: 3)]),
ExternalUserId(source: "uidapi.com", uids: [.init(id: "cat", aType: 3)]),
ExternalUserId(source: "example.com", uids: [.init(uniqueId: "dog", aType: 3)]),
ExternalUserId(source: "uidapi.com", uids: [.init(uniqueId: "cat", aType: 3)]),
],
by: updater
)

continuation.yield(.invalid)
await observation(
of: [
ExternalUserId(source: "example.com", uids: [.init(id: "dog", aType: 3)]),
ExternalUserId(source: "example.com", uids: [.init(uniqueId: "dog", aType: 3)]),
],
by: updater
)
Expand Down Expand Up @@ -148,7 +148,7 @@ final class UID2PrebidTests: XCTestCase {
)
await observation(
of: [
ExternalUserId(source: "euid.eu", uids: [.init(id: "cat", aType: 3)])
ExternalUserId(source: "euid.eu", uids: [.init(uniqueId: "cat", aType: 3)])
],
by: updater
)
Expand All @@ -164,7 +164,7 @@ final class UID2PrebidTests: XCTestCase {
)
await observation(
of: [
ExternalUserId(source: "euid.eu", uids: [.init(id: "turtle", aType: 3)])
ExternalUserId(source: "euid.eu", uids: [.init(uniqueId: "turtle", aType: 3)])
],
by: updater
)
Expand Down Expand Up @@ -205,7 +205,7 @@ extension UID2PrebidTests {
var id: String
var aType: Int
init(_ userId: UserUniqueID) {
self.id = userId.id
self.id = userId.uniqueId
self.aType = userId.aType.intValue
}
}
Expand Down
4 changes: 2 additions & 2 deletions UID2.podspec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
"tag": "v3.0.0"
},
"platforms": {
"ios": "12.0",
"tvos": "12.0"
"ios": "13.0",
"tvos": "13.0"
},
"swift_versions": [
"5"
Expand Down
2 changes: 1 addition & 1 deletion UID2Prebid.podspec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
],
"dependencies": {
"UID2": [
"~> 1.3.0"
"~> 2.1.0"
],
"PrebidMobile": [
"~> 3.1"
Expand Down
Loading