Support arguments for macro block callbacks

[leromarinvit]

No description provided.

[leromarinvit]

I'm a bit confused by the findbugs message:

[INFO] Redundant nullcheck of argName which is known to be null in com.hubspot.jinjava.lib.tag.CallTag.interpret(TagNode, JinjavaInterpreter) [com.hubspot.jinjava.lib.tag.CallTag] Redundant null check at CallTag.java:[line 118] RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE

CallTag.java:118 is a closing tag of a try-with-resources, and interpret doesn't seem to contain any explicit null checks at all. Running mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V locally doesn't yield any errors either...

[mattcoley]

I can try pulling your branch later today and see what I find.

[codecov-io]

Codecov Report

Merging #224 into master will increase coverage by 0.12%.
The diff coverage is 85.18%.

@@             Coverage Diff              @@
##             master     #224      +/-   ##
============================================
+ Coverage     71.46%   71.59%   +0.12%     
- Complexity     1376     1383       +7     
============================================
  Files           218      218              
  Lines          4356     4379      +23     
  Branches        691      696       +5     
============================================
+ Hits           3113     3135      +22     
+ Misses         1001     1000       -1     
- Partials        242      244       +2

Impacted Files	Coverage Δ	Complexity Δ
...main/java/com/hubspot/jinjava/lib/tag/CallTag.java	84.84% <85.18%> (-5.16%)	9 <6> (+5)
.../hubspot/jinjava/interpret/JinjavaInterpreter.java	78.18% <0%> (+0.6%)	49% <0%> (+1%)	⬆️
...hubspot/jinjava/el/ext/AbstractCallableMethod.java	94.11% <0%> (+5.88%)	12% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update def74f9...95f6daf. Read the comment docs.

[leromarinvit]

Found it: https://sourceforge.net/p/findbugs/bugs/1169/
Supposedly it's fixed, but at least the workaround listed there works.

[tillsc]

Shouldn't this be merged? Call block arguments are such a cool jinja feature...