Add retry middleware support for transient cURL connection errors (52/55/56)#614
Add retry middleware support for transient cURL connection errors (52/55/56)#614AScriver wants to merge 2 commits intoHubSpot:masterfrom
Conversation
|
I noticed 4 test failures in the CI run. Could you please fix them? |
|
Would it make sense to add a default delay function here? $delayFunction = function (int $retries): int {
return min(1000 * (2 ** $retries), 10000);
}; |
I checked this, and Guzzle already applies an exponential backoff when the delay function is
So the default sequence is already That said, I'm open to making the default explicit here as well if that's preferred. |
Fixes #597.
Adds opt-in retry support for transient transport-level cURL failures that currently bypass HTTP-status retry middleware.
Changes
createConnectionErrorsMiddleware(...)getRetryFunctionByConnectionErrors(...)52,55,56