Skip to content

Polishing #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m1ngyuan wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −10
Open

Polishing #1088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/main/java/org/htmlunit/css/CssPixelValueConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,6 @@ else if (value.endsWith("pc")) {
else if (value.endsWith("ch")) {
i = i * 8;
}
else if (value.endsWith("ch")) {
i = i * 8;
}
else if (value.endsWith("vh")
|| value.endsWith("vmin")) {
// this matches also
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/htmlunit/javascript/host/html/HTMLTableCellElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ public int getOffsetWidth() {
if ("collapse".equals(style.getStyleAttribute(StyleAttributes.Definition.BORDER_COLLAPSE, true))) {
final HtmlTableRow row = getRow();
if (row != null) {
w -= 0.5 * style.getBorderLeftValue();
w -= 0.5 * style.getBorderRightValue();
w -= 0.5f * style.getBorderLeftValue();
w -= 0.5f * style.getBorderRightValue();
}
}

Expand Down
6 changes: 2 additions & 4 deletions src/main/java/org/htmlunit/platform/image/ImageIOImageData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,8 @@
@SuppressWarnings("PMD.UnusedLocalVariable")
public void close() throws IOException {
if (imageReader_ != null) {
try {
try (ImageInputStream stream = (ImageInputStream) imageReader_.getInput()) {
// nothing
}
try (ImageInputStream stream = (ImageInputStream) imageReader_.getInput()) {

Check warning on line 103 in src/main/java/org/htmlunit/platform/image/ImageIOImageData.java

View workflow job for this annotation

GitHub Actions / PMD 

[PMD] reported by reviewdog 🐶
Empty try-with-resources statement. Rename the resource to `ignored`, `unused` or `_` (Java 22+).

Raw Output:
{"level":"warning","locations":[{"physicalLocation":{"artifactLocation":{"uri":"file:///home/runner/work/htmlunit/htmlunit/src/main/java/org/htmlunit/platform/image/ImageIOImageData.java"},"region":{"endColumn":14,"endLine":109,"startColumn":13,"startLine":103}}}],"message":{"text":"Empty try-with-resources statement. Rename the resource to `ignored`, `unused` or `_` (Java 22+)."},"ruleId":"EmptyControlStatement","ruleIndex":303}
// nothing
}
finally {
imageReader_.setInput(null);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/htmlunit/util/brotli/Decode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ private static void unpackCommandLookupTable(short[] cmdLookup) {
final int copyLengthOffset = copyLengthOffsets[copyCode];
final int distanceContext = distanceContextOffset + Utils.min(copyLengthOffset, 5) - 2;
final int index = cmdCode * 4;
cmdLookup[index + 0] =
cmdLookup[index] =
Copy link
Member

@rbri rbri Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not chage the any brotly decoder files, they are 1:1 taken from brotli only because the did not release for a long time

(short)
(INSERT_LENGTH_N_BITS[insertCode] | (COPY_LENGTH_N_BITS[copyCode] << 8));
cmdLookup[index + 1] = (short) insertLengthOffsets[insertCode];
Expand Down
Loading