Fix frontend URL fallback and routing issues#20
Conversation
- Added a fallback value for process.env.FRONTEND_URL in website controllers to prevent undefined paths during deploy link generation. - Created render.yaml configuration file to explicitly define SPA routing fallbacks (/* to /index.html) and properly configure frontend and backend services for Render deployments. Co-authored-by: Hrithik-05-Roshan <182404308+Hrithik-05-Roshan@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR resolves the two issues mentioned in the repo:
FRONTEND_URLcausing 404 on Deploy link.It fixes the first issue by adding a fallback to the
deployUrlgeneration inserver/controllers/website.controllers.js.It fixes the second issue by creating a
render.yamlconfiguration file for the repo, which ensures correct SPA fallback routing for the frontend and properly configures the backend service.PR created automatically by Jules for task 12589912179992790286 started by @Hrithik-05-Roshan