Skip to content

HoonJae-CodeReview/calculator

Folders and files

NameName
Last commit message
Last commit date

Latest commit

ย 

History

6 Commits
ย 
ย 
ย 
ย 

Repository files navigation

code-review

๊ฐ์ฒด์ง€ํ–ฅ ์ƒํ™œ์›์น™์„ ์ ์šฉํ•˜๊ธฐ

  • ๊ทœ์น™ 1: ํ•œ ๋ฉ”์„œ๋“œ์— ์˜ค์ง ํ•œ ๋‹จ๊ณ„์˜ ๋“ค์—ฌ์“ฐ๊ธฐ(indent)๋งŒ ํ•œ๋‹ค. ๋„์ €ํžˆ ์•ˆ๋œ๋‹ค๋ฉด ์ตœ๋Œ€ 2๊ฐœ๊นŒ์ง€
  • ๊ทœ์น™ 2: else ์˜ˆ์•ฝ์–ด๋ฅผ ์“ฐ์ง€ ์•Š๋Š”๋‹ค.
  • ๊ทœ์น™ 3: ๋ชจ๋“  ์›์‹œ๊ฐ’๊ณผ ๋ฌธ์ž์—ด์„ ํฌ์žฅํ•œ๋‹ค.
  • ๊ทœ์น™ 4: ํ•œ ์ค„์— ์ ์„ ํ•˜๋‚˜๋งŒ ์ฐ๋Š”๋‹ค.
  • ๊ทœ์น™ 5: ์ค„์—ฌ์“ฐ์ง€ ์•Š๋Š”๋‹ค(์ถ•์•ฝ ๊ธˆ์ง€). ex) BufferedReader br = new BufferedReader(); (X) -> BufferedReader bufferedReader = new BufferedReader(); (O)
  • ๊ทœ์น™ 6: ๋ชจ๋“  ์—”ํ‹ฐํ‹ฐ๋ฅผ ์ž‘๊ฒŒ ์œ ์ง€ํ•œ๋‹ค.
  • ๊ทœ์น™ 7: 3๊ฐœ ์ด์ƒ์˜ ์ธ์Šคํ„ด์Šค ๋ณ€์ˆ˜๋ฅผ ๊ฐ€์ง„ ํด๋ž˜์Šค๋ฅผ ์“ฐ์ง€ ์•Š๋Š”๋‹ค.
  • ๊ทœ์น™ 8: ์ผ๊ธ‰ ์ฝœ๋ ‰์…˜์„ ์“ด๋‹ค.
  • ๊ทœ์น™ 9: ๊ฒŒํ„ฐ/์„ธํ„ฐ/ํ”„๋กœํผํ‹ฐ๋ฅผ ์“ฐ์ง€ ์•Š๋Š”๋‹ค. ํ•„์š”ํ•˜๋ฉด ์“ฐ๊ธฐ

์ŠคํŠธ๋ฆผ๊ณผ ๋žŒ๋‹ค๋ฅผ ํ™œ์šฉํ•˜๊ธฐ

  • ์ŠคํŠธ๋ฆผ๊ณผ ๋žŒ๋‹ค๋ฅผ ์‚ฌ์šฉ ํ•  ์ˆ˜ ์žˆ๋Š” ๊ฑด ์ŠคํŠธ๋ฆผ๊ณผ ๋žŒ๋‹ค๋ฅผ ์‚ฌ์šฉํ•ด์„œ ๊ตฌํ˜„ํ•˜๊ธฐ.

AngularJS Commit Message Conventions ์ค‘

commit message ์ข…๋ฅ˜๋ฅผ ๋‹ค์Œ๊ณผ ๊ฐ™์ด ๊ตฌ๋ถ„

  • feat (feature)
  • fix (bug fix)
  • docs (documentation)
  • style (formatting, missing semi colons, โ€ฆ)
  • refactor
  • test (when adding missing tests)
  • chore (maintain)

gitignore ๋ฐ˜์˜

  • https://gitignore.io/ ์— ์ ‘์†ํ•ด์„œ ํ•„์š”ํ•œ ๋ถ€๋ถ„ ignore ๋ฐ˜์˜, gradle, maven, intellij, macOS, window ๋“ฑ๋“ฑ

์š”๊ตฌ์‚ฌํ•ญ

  • ์ฝ˜์†”๋กœ ๊ตฌํ˜„์ž…๋‹ˆ๋‹ค.(์Šค์œ™์œผ๋กœ ๊ตฌํ˜„ํ•˜์‹œ๋Š” ๋ถ„๋“ค ๊ณ„์‹ค๊นŒ๋ด)
  • ๊ฐ์ฒด์ง€ํ–ฅ์ ์ธ ์ฝ”๋“œ๋กœ ๊ณ„์‚ฐ๊ธฐ ๊ตฌํ˜„ํ•˜๊ธฐ
    • ๋”ํ•˜๊ธฐ
    • ๋นผ๊ธฐ
    • ๊ณฑํ•˜๊ธฐ
    • ๋‚˜๋ˆ„๊ธฐ
    • ์šฐ์„ ์ˆœ์œ„(์‚ฌ์น™์—ฐ์‚ฐ)
  • ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ๊ตฌํ˜„ํ•˜๊ธฐ
  • ๊ณ„์‚ฐ ์ด๋ ฅ์„ ๋งต์œผ๋กœ ๋ฐ์ดํ„ฐ ์ €์žฅ๊ธฐ๋Šฅ ๋งŒ๋“ค๊ธฐ
    • ์• ํ”Œ๋ฆฌ์ผ€์ด์…˜์ด ๋™์ž‘ํ•˜๋Š” ๋™์•ˆ ๋ฐ์ดํ„ฐ๋ฒ ์ด์Šค ์™ธ์— ๋ฐ์ดํ„ฐ๋ฅผ ์ €์žฅํ•  ์ˆ˜ ์žˆ๋Š” ๋ฐฉ๋ฒ•์„ ๊ณ ์•ˆํ•ด๋ณด์„ธ์š”.
  • (์„ ํƒ) ์ •๊ทœ์‹ ์‚ฌ์šฉ
  • ๊ฐ€๋Šฅํ•˜๋ฉด ๋‹จ์œ„ ํ…Œ์ŠคํŠธ๋„ ์ž‘์„ฑํ•˜๊ธฐ.

์‹คํ–‰๊ฒฐ๊ณผ(์ฝ˜์†”)

1. ์กฐํšŒ
2. ๊ณ„์‚ฐ

์„ ํƒ : 2

1 + 2
3

1. ์กฐํšŒ
2. ๊ณ„์‚ฐ

์„ ํƒ : 2

1 + 2 * 3
7

1. ์กฐํšŒ
2. ๊ณ„์‚ฐ

์„ ํƒ : 1

1 + 2 = 3
1 + 2 * 3 = 7

์„ ํƒ : 2

3 - 2 * 2
-1

About

No description, website, or topics provided.

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published

Contributors 2

  •  
  •