Harden signature parsing and verification edge cases#40
Open
Conversation
Base automatically changed from
codex/build-upstash-integration-on-tern
to
main
February 26, 2026 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
safeCompareto avoid multibyte-length mismatches (src/verifiers/base.ts).parseDelimitedHeader(src/verifiers/algorithms.ts).nullfor non-finite values instead of returningNaNand to explicitly parse ISO/unix/custom formats (src/verifiers/algorithms.ts).urlproperty from theReceiver.verifyinvocation so it works with SDK variants that expect onlysignatureandbody(src/upstash/queue.ts).Testing
npm testagainst the existing compiled output and the test harness executed; the suite completed and reported pre-existing failures forSanityandPolar verificationwhich are unrelated to these changes (tests otherwise passed for many platforms).npm run buildwhich failed in this environment due to missing@upstash/qstashtypes (type resolution error duringtsc).npm installto restore dependencies but it was blocked by the environment/registry (403 Forbiddenfetching a transitive dependency), preventing a full local rebuild and end-to-end TypeScript verification.Codex Task