Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ A concrete example: a 3×3 matrix whose rows and columns correspond to physical
variables with different units (position in meters, velocity in m/s, force
in N):

```jldoctest coverones
```jldoctest coverones; filter = r"(\d+\.\d{6})\d+" => s"\1"
julia> using ScaleInvariantAnalysis

julia> A = [1e6 1e3 1.0; 1e3 1.0 1e-3; 1.0 1e-3 1e-6];
Expand Down
20 changes: 5 additions & 15 deletions src/covers.jl
Original file line number Diff line number Diff line change
Expand Up @@ -151,21 +151,11 @@ function cover(A::AbstractMatrix; kwargs...)
for j in axes(A, 2)
for i in axes(A, 1)
Aij, ai, bj = abs(A[i, j]), a[i], b[j]
if iszero(bj)
if !iszero(ai)
b[j] = Aij / ai
else
a[i] = b[j] = sqrt(Aij)
end
elseif iszero(ai)
a[i] = Aij / bj
else
aprod = ai * bj
aprod >= Aij && continue
s = sqrt(Aij / aprod)
a[i] = s * ai
b[j] = s * bj
end
aprod = ai * bj
aprod >= Aij && continue
s = sqrt(Aij / aprod)
a[i] = s * ai
b[j] = s * bj
end
end
return tighten_cover!(a, b, A; kwargs...)
Expand Down
Loading