-
Notifications
You must be signed in to change notification settings - Fork 0
not sure if correct but turretsubsystem auto stubs filled #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| public class TurretSubsystem extends SubsystemBase implements Shooter { | ||
| /** Creates a new TurretSubsystem. */ | ||
| public TurretSubsystem() {} | ||
| public static double HOOD_GEAR_RATIO = 24.230769; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typically we leave this in terms of like x / y so it's easier to see what the gears actually are
| flywheelIO.updateInputs(flywheelInputs); | ||
| Logger.processInputs("Shooter/Flywheel", flywheelInputs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure to also update and process hood inputs
| shooter = | ||
| new TurretSubsystem( | ||
| ROBOT_MODE == RobotMode.REAL | ||
| ? new FlywheelIO(FlywheelIO.getFlywheelConfiguration(), canivore) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure you're not using the same getFlywheelConfiguration and getHoodConfigurations as the alpha shooter. these will need to be new methods returning diff configs
| : new FlywheelIOSim(FlywheelIO.getFlywheelConfiguration(), canivore), | ||
| ROBOT_MODE == RobotMode.REAL | ||
| ? new HoodIO(HoodIO.getHoodConfiguration(), canivore) | ||
| : new HoodIOSim(canivore)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, hoodio should probably have the motor passed in to the constructor as it's not always going to be the same motor or have the same settings. this then also means hoodiosim needs to also have the motor passed in the constructor as well as the physics sim with the physical parameters specific to the mechanism. you could make like a static getAlphaHoodSim method if that makes it easier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and same with flywheel
No description provided.