fix: apply command replacements to Bash TTS notifications

[Helmi]

Summary

• Fixes command replacements not being applied to Bash commands for TTS notifications
• Commands like "gh", "uvx", "uv" now pronounce correctly in voice notifications
• Addresses the missing apply_command_replacement() call identified in issue Command replacements not applied to Bash commands for TTS #11

Changes

• Added missing apply_command_replacement() call in Bash command processing (line 886)
• Fixed apply_command_replacement() function to properly handle "running " format
• Added default replacements for "gh" → "github CLI" and "uv" → "U V"
• Fixed function logic to preserve original command structure when no replacement found

Test Plan

• Verified command replacements work for common commands (gh, uvx, uv, npm, etc.)
• Confirmed existing functionality remains intact
• Tested both direct command replacements and pattern matching

Closes #11

[claude]

Claude finished @Helmi's task —— View job

---

PR Review Complete ✅

Review Tasks:

• Read and analyze the changed file (src/ccnotify/notify.py)
• Evaluate code quality and best practices
• Check for potential bugs or logic issues
• Assess security concerns
• Review performance considerations
• Evaluate test coverage completeness
• Provide comprehensive feedback

---

Code Review Feedback

✅ Overall Assessment

This PR successfully addresses the missing apply_command_replacement() call for Bash TTS notifications. The implementation is sound and follows the existing codebase patterns well.

🔧 Code Quality & Best Practices

Strengths:

• Consistent with existing code patterns - The fix follows the same approach used elsewhere in the codebase
• Well-structured logic - The apply_command_replacement() function properly handles both "running " patterns and direct command replacements
• Good error handling - Function gracefully returns original text when no replacement is found
• Appropriate placement - The fix is correctly placed at line 896 within the Bash command processing logic

Areas for improvement:

• Consider adding type hints to the apply_command_replacement() function parameters for better code documentation
• The function could benefit from a docstring explaining the "running" prefix behavior

🐛 Bug Analysis

Fixed Issues:

• ✅ Primary bug resolved - Commands like "gh", "uvx", "uv" now correctly apply replacements in TTS
• ✅ Pattern matching works - Both direct command replacements and regex patterns are properly applied
• ✅ Preserves structure - The fix maintains the original command structure when no replacement is found

No new bugs identified - The implementation is safe and follows defensive programming practices.

🔒 Security Assessment

No security concerns identified:

• The function only processes text replacements for TTS pronunciation
• No external API calls or file system operations
• Input sanitization is appropriate for the use case
• No risk of command injection or other security vulnerabilities

⚡ Performance Considerations

Efficient implementation:

• Minimal overhead - The function uses simple string operations and regex matching
• Early returns - Logic uses early returns to avoid unnecessary processing
• Cached patterns - Regex patterns are loaded once from configuration
• No performance regressions - The fix only adds one function call to existing logic

🧪 Test Coverage Evaluation

Test Plan Analysis:

• ✅ Manual testing completed - PR author verified command replacements work for common commands
• ✅ Regression testing - Confirmed existing functionality remains intact
• ✅ Pattern testing - Both direct and pattern matching tested

Suggestions for enhanced testing:

• Consider adding unit tests for the apply_command_replacement() function
• Edge case testing could include empty strings, special characters, and very long commands

📝 Specific Code Comments

Line 896 - src/ccnotify/notify.py:896:

audio_desc = apply_command_replacement(audio_desc, replacements)

✅ Perfect placement - This is exactly where the call needed to be added to fix the TTS pronunciation issue.

Lines 597-616 - src/ccnotify/notify.py:597-616:
The logic for handling "running " format is well-implemented:

• Correctly identifies "running" prefix
• Preserves command structure
• Handles both cases (with and without "running" prefix)

🎯 Final Recommendations

Ready to merge with minor enhancements:

1. Consider adding a unit test for apply_command_replacement() to prevent future regressions
2. Optional: Add type hints to improve code documentation
3. Optional: Add docstring explaining the function's behavior with "running" prefix

This PR effectively resolves issue #11 and improves the user experience for TTS notifications without introducing any risks or breaking changes.

---