Update build-test-pack.yml#10
Merged
Merged
Conversation
I am not sure if this is correct or sufficient, but to ensure consistent compatibility across all native components shipped by Helion, I would like to use the "Ubuntu 22.04" runner for Linux native binaries and the "Windows 2022" runner for Windows native binaries at this time. I am not merging this to the main branch because I do not know if other changes might be needed for this not to break something.
Collaborator
|
Tests are still running fine so seems good to me! Since the OS was only changed in the build job, it also adds testing for OS being newer than the one that built the library, so that's good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure if this is correct or sufficient, but to ensure consistent compatibility across all native components shipped by Helion, I would like to use the "Ubuntu 22.04" runner for Linux native binaries and the "Windows 2022" runner for Windows native binaries at this time.
I am not merging this to the main branch because I do not know if other changes might be needed for this not to break something.