Wire up AGP Compose Preview screenshot tests in feature-purchase-apartment (RND-1965)#2954
Closed
hugokallstrom wants to merge 14 commits into
Closed
Wire up AGP Compose Preview screenshot tests in feature-purchase-apartment (RND-1965)#2954hugokallstrom wants to merge 14 commits into
hugokallstrom wants to merge 14 commits into
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ls, and GraphQL Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…re module restriction The hedvig.gradle.plugin prevents feature modules from depending on other feature modules. Moving the shared purchase code out of the feature/ directory makes it a library module that feature modules can depend on. Also fixes: Apollo fragment resolution (each module gets its own fragment), Material3 dropdown replaced with design system DropdownWithDialog. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…uting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Shows a HedvigNotificationCard with error priority when the form submission fails, instead of silently swallowing the error. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary screen now shows an error notification card when add-to-cart or start-sign fails, instead of navigating to a separate failure screen. Signing screen now shows an error with retry button when polling fails or signing is rejected, instead of navigating away. Removed the Failure destination from both nav graphs since all errors are now handled inline with retry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ng screen, remove form titles Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…er flow Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…-apartment Adds the com.android.compose.screenshot plugin (alpha15) so @previewTest composables render to PNGs on the JVM via LayoutLib. Sets the apartment form's filled-state preview as the first screenshot test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.android.compose.screenshotplugin (alpha15) so Compose@Previewcomposables annotated with@PreviewTestrender to PNGs on the JVM via LayoutLib — no emulator needed.feature-purchase-apartmentas the canonical reference module: experimental flag, screenshotTest dependencies, and one@PreviewTestrenderingApartmentFormContentin its filled state.ApartmentFormContentfromprivatetointernalso the screenshotTest source set can call it.Test plan
./gradlew :feature-purchase-apartment:updateDebugScreenshotTestsucceeds and writes the reference PNG tosrc/screenshotTestDebug/reference/..../gradlew :feature-purchase-apartment:validateDebugScreenshotTestpasses against the committed referenceStorgatan 1/12345/65/Du + 1and theBeräkna prisbutton🤖 Generated with Claude Code