Skip to content

Bump pydantic, update test matrix and schema#130

Open
qplevier wants to merge 3 commits into
mainfrom
deps/bump-pydantic
Open

Bump pydantic, update test matrix and schema#130
qplevier wants to merge 3 commits into
mainfrom
deps/bump-pydantic

Conversation

@qplevier
Copy link
Copy Markdown
Contributor

@qplevier qplevier commented May 4, 2026

Upgrade pydantic to ~=2.13.0 and adjust supported Python versions in the test matrix (drop 3.8, add 3.13 and 3.14). Remove the Python 3.8 classifier. Also normalize numeric types in models/time/DateTimeDescription.json by changing second.exclusiveMaximum and second.minimum from floats to integers.

Summary by Sourcery

Upgrade core dependencies and update supported Python versions.

Enhancements:

  • Update pydantic dependency to version ~=2.13.0.
  • Normalize numeric bounds types in DateTimeDescription schema from floats to integers.

Build:

  • Adjust project classifiers to drop Python 3.8 support.
  • Update test matrix to drop Python 3.8 and add Python 3.13 and 3.14.

Upgrade pydantic to ~=2.13.0 and adjust supported Python versions in the test matrix (drop 3.8, add 3.13 and 3.14). Remove the Python 3.8 classifier. Also normalize numeric types in models/time/DateTimeDescription.json by changing second.exclusiveMaximum and second.minimum from floats to integers.
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 4, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Upgrades core dependencies and supported Python versions, and normalizes a JSON schema field’s numeric types, requiring reviewers to focus on compatibility and schema correctness.

ER diagram for updated DateTimeDescription JSON schema

erDiagram
  DateTimeDescription {
    string id
    string description
  }

  SecondConstraint {
    int second_minimum
    int second_exclusiveMaximum
  }

  DateTimeDescription ||--o{ SecondConstraint : has_second_constraints
Loading

File-Level Changes

Change Details Files
Update supported Python versions and dependency constraints to reflect dropping Python 3.8, adding newer CPython versions, and bumping pydantic.
  • Removed Python 3.8 from the Trove classifiers in pyproject configuration.
  • Bumped pydantic dependency from ~=2.10.6 to ~=2.13.0 in project dependencies.
  • Updated Hatch test environment matrix to drop Python 3.8 and add Python 3.13 and 3.14 while retaining existing PyPy entries.
pyproject.toml
Normalize numeric constraints in the DateTimeDescription JSON schema.
  • Changed second.exclusiveMaximum from a floating-point value to an integer value to match the intended numeric type.
  • Changed second.minimum from a floating-point value to an integer value for consistency with other numeric bounds.
models/time/DateTimeDescription.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The Trove classifiers still only list up to Python 3.12 while the test matrix includes 3.13 and 3.14; consider adding corresponding Programming Language :: Python :: 3.13 and 3.14 classifiers to keep the metadata aligned with supported/tested versions.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The Trove classifiers still only list up to Python 3.12 while the test matrix includes 3.13 and 3.14; consider adding corresponding `Programming Language :: Python :: 3.13` and `3.14` classifiers to keep the metadata aligned with supported/tested versions.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant