Bump pydantic, update test matrix and schema#130
Open
qplevier wants to merge 3 commits into
Open
Conversation
Upgrade pydantic to ~=2.13.0 and adjust supported Python versions in the test matrix (drop 3.8, add 3.13 and 3.14). Remove the Python 3.8 classifier. Also normalize numeric types in models/time/DateTimeDescription.json by changing second.exclusiveMaximum and second.minimum from floats to integers.
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpgrades core dependencies and supported Python versions, and normalizes a JSON schema field’s numeric types, requiring reviewers to focus on compatibility and schema correctness. ER diagram for updated DateTimeDescription JSON schemaerDiagram
DateTimeDescription {
string id
string description
}
SecondConstraint {
int second_minimum
int second_exclusiveMaximum
}
DateTimeDescription ||--o{ SecondConstraint : has_second_constraints
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The Trove classifiers still only list up to Python 3.12 while the test matrix includes 3.13 and 3.14; consider adding corresponding
Programming Language :: Python :: 3.13and3.14classifiers to keep the metadata aligned with supported/tested versions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The Trove classifiers still only list up to Python 3.12 while the test matrix includes 3.13 and 3.14; consider adding corresponding `Programming Language :: Python :: 3.13` and `3.14` classifiers to keep the metadata aligned with supported/tested versions.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Upgrade pydantic to ~=2.13.0 and adjust supported Python versions in the test matrix (drop 3.8, add 3.13 and 3.14). Remove the Python 3.8 classifier. Also normalize numeric types in models/time/DateTimeDescription.json by changing second.exclusiveMaximum and second.minimum from floats to integers.
Summary by Sourcery
Upgrade core dependencies and update supported Python versions.
Enhancements:
Build: