Feature/update settings autocomplete #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added isSameSchema function, allowing RDF models to be compared. - Added GetAllSchemas function, fetching all current schemas in the FDP. - Added SchemaToolsTest.java, testing this new feature. - Improved readability in SchemaTools.java by splitting up functons inside run.
…date' into feature-update-schema-improvements # Conflicts: # src/main/java/nl/healthri/fdp/uploadschema/utils/RdfUtils.java
- removed redundant custom request builder, Java request library already has a builder which leaded to unnessesary complexity. - Added improved general response handling based on swagger documentation of FDP. - Changed timeout from 500ms to 30000ms, this was causing requests not to be made and because of limited error handling not noticed either. - Added integration folder for external API integrations (FDP) - Added DTO's with Requests and Responses - Removed unused code - Renamed files for naming consistency
- Clear folder structure - Split FDP into FdpClient, FdpService and IFdpClient according to SOLID principles
…from client to service
…d DTO fields when mapping to prevent exceptions.
…cessary complexity
…ases for ResourceTaskService
…resource, task.uuid and task.shapeUUUID
…teResourceTasks and added tests for these functions
… multiple scenarios
…nCreatingTasks_ReturnsTasksThatExist
… and new settings.
feat: Added tests for settings
|
…n thread exception handling
…and content type usage to constants
…tocomplete # Conflicts: # src/main/java/nl/healthri/fdp/uploadschema/SchemaTools.java # src/main/java/nl/healthri/fdp/uploadschema/integrations/FdpClient.java # src/main/java/nl/healthri/fdp/uploadschema/integrations/FdpClientInterface.java # src/main/java/nl/healthri/fdp/uploadschema/services/ResourceTaskService.java
|
hcvdwerf
requested changes
Jan 16, 2026
| "resourceUri": "https://www.wikidata.org/wiki/Q8777" | ||
| } | ||
| ], | ||
| "ping": { |
Contributor
There was a problem hiding this comment.
Why is this enabled by default? is this not unnecessary traffic?
| "forms": { | ||
| "autocomplete": { | ||
| "searchNamespace": true, | ||
| "sources": [ |
Contributor
There was a problem hiding this comment.
I think this part you don't want in the default FDP schema tool . Please use the default settings
Contributor
There was a problem hiding this comment.
Maybe you can make a copy of this one , because it is useful information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.