Feature update schema improvements #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added isSameSchema function, allowing RDF models to be compared. - Added GetAllSchemas function, fetching all current schemas in the FDP. - Added SchemaToolsTest.java, testing this new feature. - Improved readability in SchemaTools.java by splitting up functons inside run.
…date' into feature-update-schema-improvements # Conflicts: # src/main/java/nl/healthri/fdp/uploadschema/utils/RdfUtils.java
|
PatrickDekkerHealthRI
suggested changes
Oct 23, 2025
Contributor
PatrickDekkerHealthRI
left a comment
PatrickDekkerHealthRI
left a comment
There was a problem hiding this comment.
In the FDP GetAllSchema can be removed i think ?
Comment on lines
+189
to
+234
|
|
||
| public List<SchemaDataResponse> GetAllSchemas(){ | ||
| logger.info("Getting all metadata schemas"); | ||
| try { | ||
| HttpClient client = HttpClient.newBuilder() | ||
| .build(); | ||
|
|
||
| HttpRequest request = HttpRequest.newBuilder() | ||
| .GET() | ||
| .uri(new URI(url + "/metadata-schemas/")) | ||
| .header("accept", "application/json") | ||
| .header("Content-Type", "application/json") | ||
| .header("Authorization", String.valueOf(token)) | ||
| .build(); | ||
|
|
||
| HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString()); | ||
|
|
||
| // Handle each response based on Fair Data Point (FDP) Swagger documentation. | ||
| switch (response.statusCode()) { | ||
| case 200 -> logger.info("Successfully received all schemas from FDP"); | ||
| case 400 -> | ||
| throw new IllegalArgumentException(String.valueOf(HttpStatus.SC_BAD_REQUEST)); | ||
| case 401 -> | ||
| throw new SecurityException(String.valueOf(HttpStatus.SC_UNAUTHORIZED)); | ||
| case 403 -> | ||
| throw new SecurityException(String.valueOf(HttpStatus.SC_FORBIDDEN)); | ||
| case 404 -> | ||
| throw new IOException(String.valueOf(HttpStatus.SC_NOT_FOUND)); | ||
| case 500 -> | ||
| throw new IOException(String.valueOf(HttpStatus.SC_INTERNAL_SERVER_ERROR)); | ||
| default -> { | ||
| throw new RuntimeException("Unexpected HTTP status: " + response.statusCode()); | ||
| } | ||
| } | ||
|
|
||
| ObjectMapper objectMapper = new ObjectMapper(); | ||
| TypeReference<List<SchemaDataResponse>> schemaDataTypeReference = new TypeReference<List<SchemaDataResponse>>(){}; | ||
| List<SchemaDataResponse> schemaDataResponseList = objectMapper.readValue(response.body(), schemaDataTypeReference); | ||
|
|
||
| return schemaDataResponseList; | ||
|
|
||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Please remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.