Skip to content

fix(ready.js): Refactor FS API & CRON JOB#8

Open
iLollek wants to merge 1 commit into
Hazeolation:mainfrom
iLollek:patch-1
Open

fix(ready.js): Refactor FS API & CRON JOB#8
iLollek wants to merge 1 commit into
Hazeolation:mainfrom
iLollek:patch-1

Conversation

@iLollek
Copy link
Copy Markdown

@iLollek iLollek commented May 28, 2025

This Change implements the following things I have found when analyzing the Code:

  • The CRON Expression is not correct if you want to run it on a Sunday as the comment says.

'00 00 23 * *7' to '00 00 23 * * 0' (Sunday = 0, not 7)

  • The FS API is more robust now since it's Promise-Based (await)

Changed fs.writeFileSync() to await fs.writeFile()

Comment thread Events/ready.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants