Fix diagonal movement #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When allowing diagonals, entities were able to cross through walls that have touching vertices. Moreover, the code allowed for entities to enter halfway into a wall.
|
I'm not familiar with this library so I'll have to look into it before merging. After a quick look I'm a bit confused, the horizontal neighbors are added without check so I assumed this is done in the search but it doesn't look like it's the case either. So yeah I'll have to investigate that ;) |
Member
Author
|
Bumpity bump, in case anyone else uses this, the fix does fix things, so it might be a good idea to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entities were able to execute diagonal moves that made them cross one or two illegal tiles.