fix: pin pandas and numpy to prevent strict typing crashes#18
Open
andrewendlinger wants to merge 1 commit intoHawkMRS:mainfrom
Open
fix: pin pandas and numpy to prevent strict typing crashes#18andrewendlinger wants to merge 1 commit intoHawkMRS:mainfrom
andrewendlinger wants to merge 1 commit intoHawkMRS:mainfrom
Conversation
Pins pandas to <2.2.0 and numpy to <2.0.0 in package requirements. Recent updates to these libraries introduced strict type enforcement (e.g., preventing implicit upcasting), which causes LossySetitemError and empty DataFrame AttributeErrors during standard pyAMARES workflows. This temporary restriction restores immediate stability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #17
What does this PR do?
Restricts the allowed versions of
pandas(< 2.2.0) andnumpy(< 2.0.0) in the package dependencies.Why is this necessary?
Recent releases of Pandas and NumPy introduced strict type-enforcement and removed implicit upcasting. This causes the current
pyAMAREScodebase to crash withLossySetitemError(during unit conversions) andAttributeError(when manipulating empty DataFrames resulting from peak filtering).By pinning these dependencies to their last known stable versions, we immediately restore usability for end-users (at least python 3.11 and 3.12 it seems) while we can work on a comprehensive codebase update in a separate PR.