fix: use PEP 508 environment markers for hlsvdpro (Resolves #15)#16
Open
andrewendlinger wants to merge 1 commit intoHawkMRS:mainfrom
Open
fix: use PEP 508 environment markers for hlsvdpro (Resolves #15)#16andrewendlinger wants to merge 1 commit intoHawkMRS:mainfrom
andrewendlinger wants to merge 1 commit intoHawkMRS:mainfrom
Conversation
andrewendlinger
force-pushed
the
fix/15-hlsvdpro-marker
branch
from
72b19c1 to
cb9607f
Compare
andrewendlinger
force-pushed
the
fix/15-hlsvdpro-marker
branch
from
cb9607f to
cfb3a8c
Compare
Contributor
Author
|
Looks like some dependencies introduced breaking changes with python 3.11 and above? The CI/CD failure is very likely not related to this PR. |
andrewendlinger
force-pushed
the
fix/15-hlsvdpro-marker
branch
from
e403938 to
cfb3a8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #15
What does this PR do?
This PR moves the platform-specific requirement for
hlsvdprofrom a build-time Pythonifstatement into an install-time PEP 508 environment marker within theinstall_requireslist.Why is this necessary?
Previously, because the PyPI wheels were built on x86_64 machines,
hlsvdprowas permanently baked into the static wheel metadata as a requirement for all platforms. This caused strict, metadata-first package managers likeuv(and modernpip) to crash on Apple Silicon (ARM64) Macs when they couldn't find a matching wheel.By using environment markers, the platform evaluation now correctly happens on the user's machine at install-time, bypassing
hlsvdpronatively on ARM64 architectures while preserving it for Intel/AMD users.Changes:
if platform.machine().lower() in ["x86_64", "amd64"]:block insetup.py."hlsvdpro>=2.0.0; platform_machine == 'x86_64' or platform_machine == 'amd64'"directly toinstall_requires.