Skip to content

fix: Remove v1+v2, defaulting to v1#243

Merged
kriszyp merged 1 commit intomainfrom
remove-v1-and-v2-exports
Mar 17, 2026
Merged

fix: Remove v1+v2, defaulting to v1#243
kriszyp merged 1 commit intomainfrom
remove-v1-and-v2-exports

Conversation

@dawsontoth
Copy link
Contributor

I'm not convinced that the package.json exports is correct, or perhaps that the dist/index.d.ts is correct, but we're getting closer.

@dawsontoth dawsontoth requested a review from a team as a code owner March 17, 2026 16:12
@dawsontoth dawsontoth mentioned this pull request Mar 17, 2026
@cb1kenobi
Copy link
Contributor

I'm not convinced that the package.json exports is correct, or perhaps that the dist/index.d.ts is correct, but we're getting closer.

I agree, exports in the package.json is not correct. Should probably be:

"module": "./dist/index.js",
"exports": {
	".": {
		"import": "./dist/index.js",
		"types": "./dist/index.d.ts"
	}
}

@kriszyp kriszyp merged commit 971bac7 into main Mar 17, 2026
20 of 22 checks passed
@kriszyp kriszyp deleted the remove-v1-and-v2-exports branch March 17, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants