This repository was archived by the owner on Jun 1, 2024. It is now read-only.
[Feature Request 2985] Custom username editor#3309
Open
edonaHajredinaj wants to merge 2 commits intoHaptic-Apps:masterfrom
Open
[Feature Request 2985] Custom username editor#3309edonaHajredinaj wants to merge 2 commits intoHaptic-Apps:masterfrom
edonaHajredinaj wants to merge 2 commits intoHaptic-Apps:masterfrom
Conversation
Member
|
@edonaHajredinaj Just a few nitpicks I have: please make |
Member
|
@edonaHajredinaj Any updates? |
Member
|
Guess I'll do it myself then... |
This comment has been minimized.
This comment has been minimized.
Member
|
@edonaHajredinaj No worries, I've already done it :) |
Alexendoo
suggested changes
Jan 10, 2021
Member
Alexendoo
left a comment
Alexendoo
left a comment
There was a problem hiding this comment.
Thanks for the PR, just some R.string.* changes needed (allows them to be translated into different languages)
Collaborator
|
I've updated the string resources, we should use the AlertDialogWrapper for better theming of this popup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Feature Request 2985, Added a custom username editor so that users can hide their username if someone looks at their phone screen.