fix(VRSL): apply outputConfig to VRSL deserializer#28
Merged
Happyrobot33 merged 2 commits intoMay 12, 2026
Conversation
I was going to change these anyways. I just need to make at least one commit, so I can make a PR, and then commit all my changes from my PC and then ask Happy to review the PR when I commited my changes
Changes: - Added the outputConfig X and Y offsetting to the deserializer, like how the serializer did it. - Also increased the default TranscodeUniverseCount value to 9 instead of 3 - Made sure some division stuff is more consistant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix the VRSL deserializer NOT applying the outputConfig setting value.
Current problem:
The VRSL deserializer currently does not want to grab pixels from HorizontalBottom, VerticalLeft or VerticalRight layouts. This is due to the X/Y offset system being hardcoded for HorizontalTop